Repository navigation
Fix false Windows Vulkan device warning in setup - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V's Windows os.execute rejects
&&, so the setup check never ran vulkaninfo and reported a false missing-device warning on a working GPU.Change the working directory through os.chdir, run the probe directly and restore the caller's directory. Add a GPU-independent regression probe to the stable Linux, macOS and Windows CI lanes; it checks success, a failed child and the temporary working directory with an executable path containing spaces.
Validation: Windows/MSVC regression checks passed; the real check now enumerates this machine's GPU. Vulkan ergonomic tests: 5 passed. git diff --check passed.