fix(tools): preserve an explicitly empty description - #1913
Open
codewithfourtix wants to merge 2 commits into
Open
fix(tools): preserve an explicitly empty description#1913codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new test is not skipped under PYDANTIC_V1, so it will fail in Pydantic v1 environments where beta_tool raises RuntimeError.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR fixes beta_tool(..., description="") so an explicitly empty description is preserved instead of falling back to the function docstring, only using the docstring when description is None.
Changes:
- Update tool initialization to treat
description=""as an explicit value (fallback only onNone). - Add a parametrized test covering empty, replacement, and
Nonedescriptions forbeta_tool.
File summaries
| File | Description |
|---|---|
src/anthropic/lib/tools/_beta_functions.py |
Adjusts description fallback logic to distinguish None from empty strings. |
tests/lib/tools/test_functions.py |
Adds regression coverage ensuring explicit empty descriptions are preserved. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
description=""tobeta_toolcurrently restores the function docstring. Only fall back to the docstring when the argument isNone, so callers can explicitly clear a description.Adds tests for empty, custom, and omitted descriptions.