Skip to content

fix: resolve code quality issues identified in analysis #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve code quality issues identified in analysis #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions results/aHR0cHM6Ly9iZXRhLmdvdXYuZnIv/20210425_233709/lhr.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@
--report-text-color: var(--color-gray-100);
--snippet-color: var(--color-cyan-500);
--topbar-background-color: var(--color-gray);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);

/* SVGs */
--plugin-icon-url: var(--plugin-icon-url-dark);
Expand Down Expand Up @@ -3734,6 +3734,7 @@
displayedHost = parsed.file === '/' || parsed.hostname === '' ? '' : `(${parsed.hostname})`;
title = url;
} catch (e) {
console.warn('Could not parse URL:', e); // eslint-disable-line no-console
displayedPath = url;
}

Expand Down Expand Up @@ -3763,7 +3764,9 @@
let url;
try {
url = new URL(details.url);
} catch (_) {}
} catch (_) {
console.warn('Could not parse URL:', _); // eslint-disable-line no-console
}

if (!url || !allowedProtocols.includes(url.protocol)) {
// Fall back to just the link text if invalid or protocol not allowed.
Expand Down Expand Up @@ -7534,6 +7537,7 @@
try {
formatter = new Intl.DateTimeFormat(this._numberDateLocale, options);
} catch (err) {
console.warn('Could not format date, falling back to UTC:', err); // eslint-disable-line no-console
options.timeZone = 'UTC';
formatter = new Intl.DateTimeFormat(this._numberDateLocale, options);
}
Expand Down
10 changes: 5 additions & 5 deletions results/aHR0cHM6Ly9iZXRhLmdvdXYuZnIv/20210428_213635/lhr.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@
--report-text-color: var(--color-gray-100);
--snippet-color: var(--color-cyan-500);
--topbar-background-color: var(--color-gray);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);
--toplevel-warning-background-color: #544B40;
--toplevel-warning-message-text-color: var(--color-orange-700);
--toplevel-warning-text-color: var(--color-gray-100);

/* SVGs */
--plugin-icon-url: var(--plugin-icon-url-dark);
Expand Down Expand Up @@ -3412,7 +3412,7 @@
if (typeof module !== 'undefined' && module.exports) {
module.exports = DOM;
} else {
self.DOM = DOM;
globalThis.DOM = DOM;
}
;
/*
Expand Down Expand Up @@ -3512,7 +3512,7 @@
});
}
function polyfillToggleEvent() {
if (window.MutationObserver) {
if (globalThis.MutationObserver) {
new MutationObserver(function(mutations) {
forEach.call(mutations, function(mutation) {
var target = mutation.target, attributeName = mutation.attributeName;
Expand Down