fix(opencode): terminate local MCP process trees - #46312
Open
YidiDev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46253
Related to #46035.
Type of change
What does this PR do?
Local stdio MCP launchers can leave descendant processes running after disconnect or replacement because those paths only close the direct client transport. This change centralizes the descendant cleanup already used by instance teardown and applies it whenever a connected client is released, including post-connect initialization failure.
The regression fixture starts a real child process and verifies that replacement terminates the previous parent and child before disconnect separately terminates the current parent and child.
How did you verify your code works?
bun test test/mcp/lifecycle.test.ts --timeout 30000(22 pass, 0 fail)bun run typecheckgit diff --checkThe new PID-based regression failed before the production change because the child remained alive, and passes after it.
Screenshots / recordings
Not applicable; this is process lifecycle behavior covered by an integration test.
Checklist