Skip to content

fix(desktop): prevent update downgrades #46277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opencode-agent wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix(desktop): prevent update downgrades #46277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/desktop/src/main/updater/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { expect, test } from "bun:test"
import { configureStableUpdates } from "./config"

test("stable updates do not install older releases", () => {
const client = {
channel: null,
allowPrerelease: null,
allowDowngrade: true,
}

configureStableUpdates(client)

expect(client).toEqual({
channel: "latest",
allowPrerelease: false,
allowDowngrade: false,
})
})
11 changes: 11 additions & 0 deletions packages/desktop/src/main/updater/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
type UpdateClient = {
channel: string | null
allowPrerelease: boolean | null
allowDowngrade: boolean
}

export function configureStableUpdates(client: UpdateClient) {
client.channel = "latest"
client.allowPrerelease = false
client.allowDowngrade = false
}
5 changes: 2 additions & 3 deletions packages/desktop/src/main/updater/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { app, autoUpdater } from "electron"
import pkg from "electron-updater"
import { Effect } from "effect"
import { setAppQuitting } from "../windows"
import { configureStableUpdates } from "./config"
import type { Platform } from "./index"

const updateClient = pkg.autoUpdater
Expand All @@ -15,9 +16,7 @@ export const make = Effect.gen(function* () {
error: (...args) => runFork(Effect.logError(...args)),
debug: (...args) => runFork(Effect.logDebug(...args)),
}
updateClient.channel = "latest"
updateClient.allowPrerelease = false
updateClient.allowDowngrade = true
configureStableUpdates(updateClient)
updateClient.autoDownload = false
updateClient.autoInstallOnAppQuit = process.platform === "darwin"
yield* Effect.logInfo("auto updater configured", {
Expand Down
Loading