fix: allow custom provider models in generated config schema - #46271
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: allow custom provider models in generated config schema#46271BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46248
Type of change
What does this PR do?
restoreModelRefsinpackages/opencode/script/schema.tswas applying$ref: https://models.dev/model-schema.json#/$defs/Modelas a sibling on everymodel/small_modelstring field. That$defs/Modelis a closed enum, so a valid custom provider id such asinternal/Qwen/Qwen3-Coder-30B-A3B-Instructfailed generated-schema validation even though runtimeConfigV1.modelis a plain string.This change emits
anyOf: [{ type: "string" }, { $ref }]instead of the sibling$ref, so custom ids validate and the models.dev branch can still be used for autocomplete. The same helper covers top-levelmodel/small_modeland nested agent/commandmodelfields.How did you verify your code works?
3 tests: generated Config.model / small_model keep a string branch (no closed-enum-only
$ref); the issue's custom provider model validates; a normal models.dev id still validates.Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist