fix(app): reveal scrollbar in settings dialog panels - #46260
Open
JaapHaitsma wants to merge 2 commits into
Open
Conversation
The settings dialog panels scrolled but hid their scrollbar entirely, so there was no indication content continued below the fold (e.g. the Appearance / Color scheme setting) and no thumb to drag. Route the General, Keybinds, Providers and Models panels — in both the current and new-layout dialogs — through the shared ScrollView so a thumb reveals on hover. Also make ScrollView defer to a descendant that already handled a key (e.defaultPrevented) so it no longer scrolls the panel when a focused dropdown is opened with the arrow keys.
The settings dialog tabs now wrap their content in ScrollView so a thumb reveals on hover, which left .settings-v2-panel's own overflow-y/hidden- scrollbar rules redundant there — and they were the original source of the invisible scrollbar. They are not dead globally, though: the Manage Models dialog has no ScrollView and relies on that element being the scroll container, both to scroll at all and to drive its scroll-timeline top fade in index.css. So move the declarations to a .settings-v2-panel--scroll modifier and apply it there instead of deleting them. The scroll-timeline selector still matches, since the element keeps the base class. No behavior change: the five settings tabs already scrolled via ScrollView, and Manage Models keeps its bare scroller.
Member
|
feel free to resubmit this PR but we're working on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmits #35555, which was closed by the automated PR cleanup before maintainers had a chance to review. Rebased onto current
dev.The settings dialog panels scrolled but hid their scrollbar entirely, so there was no indication content continued below the fold (e.g. the Appearance / Color scheme setting) and no thumb to drag. Route the General, Keybinds, Providers and Models panels — in both the current and new-layout dialogs — through the shared ScrollView so a thumb reveals on hover.
Also make ScrollView defer to a descendant that already handled a key (e.defaultPrevented) so it no longer scrolls the panel when a focused dropdown is opened with the arrow keys.
Issue for this PR
Closes #34108
Type of change
What does this PR do?
It introduces the same thin scrollbar that appears on hover as in other windows and dialogs in the settings. There was no indication before and with keyboard you could not scroll in the settings dialog. Also a mouse without a scroll wheel could not interact with it
How did you verify your code works?
I ran the Desktop app
Screenshots / recordings
and in the new layout
Checklist