feat(tui): add off mode for thinking blocks - #46234
Open
yauhenifutryn wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40671
Type of change
What does this PR do?
Adds an opt-in
offstate to the persisted TUI thinking display mode./thinkingnow cyclesshow -> hide -> off -> show. Unlike collapsedhide,offremoves the complete reasoning subtree, including live spinners, completed headers, opaque placeholders, bodies, and spacing. Model reasoning, stored parts, provider streams, and transcript exports are unchanged.How did you verify your code works?
packages/tuisuite: 199 passed, 1 skipped, 0 failedhiderendered 25 visibleThoughttokens;offrendered 0Thoughtand 0ThinkingtokensScreenshots / recordings
TUI capture comparison from the same 120-row tmux viewport:
Checklist