fix(app): encode server credentials as UTF-8 - #46225
Open
sdivyanshu90 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46224
Type of change
What does this PR do?
The app passed
username:passworddirectly tobtoa(), which either encoded non-ASCII credentials with the wrong bytes or threwInvalidCharacterError. This change converts the credential string to UTF-8 bytes before standard Base64 encoding, matching the server decoder. Regression tests cover both Latin-1-range and multibyte credentials while preserving the existing ASCII result.How did you verify your code works?
From
packages/appat reduced process priority:bun test src/utils/server.test.ts src/utils/server-health.test.ts src/utils/server-protocol.test.ts src/utils/server-compat.test.ts src/utils/terminal-websocket-url.test.ts— 30 tests passedbun typecheck— passedScreenshots / recordings
Not applicable. This changes authentication encoding logic without changing the rendered UI.
Checklist