Repository navigation
fix(ssh): support interactive PTY sessions and optional X11 forwarding - #80
Conversation
Add typed terminal sessions with bounded byte streaming, input, resizing, cancellation, and lifecycle cleanup. Preserve exec/start behavior and require explicit terminal and X11 authorization. Include host adapter references, plugin example, tests, and FDO integration handoff. Compatible host wiring is required.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Coverage Report
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91874967e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| void opening.then(value => { if (stopped) closeLate(value); }, () => {}); | ||
| try { | ||
| host = await Promise.race([opening, localEnd.then(() => fail('CANCELLED'))]); |
There was a problem hiding this comment.
When configureHostServices(null) or a replacement configuration runs while openSSHTerminal() is still pending, this open has not yet been added to activeResources, and this race only observes the adapter promise and an explicit abort. Without an aborted caller signal, the returned openTerminal() promise can therefore remain pending indefinitely, even though the old transport is no longer current, and any eventual host session is not closed until the adapter finally resolves. Register pending opens for host-service lifecycle cleanup or race them against configuration invalidation.
Useful? React with 👍 / 👎.
1 participant
Add typed terminal sessions with bounded byte streaming, input, resizing, cancellation, and lifecycle cleanup. Preserve exec/start behavior and require explicit terminal and X11 authorization.
Include host adapter references, plugin example, tests, and FDO integration handoff. Compatible host wiring is required.