Repository navigation
fix(ng-dev/pr): prevent CheckRun status map fallthrough and require CheckRun type in assertSignedCla - #4041
Merged
Conversation
…SignedCla and prevent CheckRun status map overwrite\"" This reverts commit 1ae310e.
Google CLA check results are reported as a CheckRun (type "check") by the Google CLA GitHub App rather than a commit status (type "status"). Update assertSignedCla to require type === 'check' for cla/google.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request resolves potential collisions between GitHub CheckRuns and StatusContexts with identical names by prefixing status map keys with their respective types, and adds missing break statements to the switch block in getStatusesForPullRequest. Additionally, the CLA validation is updated to specifically require a passing CheckRun of type 'check' named 'cla/google', supported by new unit tests. I have no further feedback to provide as there are no review comments.
alan-agius4
approved these changes
Oct 14, 2026
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies the fix for preventing CheckRun fallthrough into StatusContext and isolating CheckRun and StatusContext entries in statusMap from commit a43054d (reverted in 1ae310e), followed by updating assertSignedCla to require type === 'check' matching the CheckRun status type reported by the Google CLA GitHub App.