Repository navigation
Revert "fix(ng-dev/pr): require commit status type in assertSignedCla and prevent CheckRun status map overwrite" - #4039
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the status mapping logic in fetch-pull-request.ts and simplifies the CLA validation logic. The reviewer identified a critical bug where the removal of break statements in the switch block causes an unintended fall-through, which will lead to runtime errors when processing CheckRun contexts. The associated tests for CLA validation were also removed as part of these changes.
alan-agius4
changed the title
… and prevent CheckRun status map overwrite" This reverts commit a43054d.
alan-agius4
force-pushed
the
revert-cla-status-check
branch
from
October 14, 2026 16:40
99e6558 to
84cf0cc
Compare
clydin
approved these changes
Oct 14, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a43054d.