fix(material/sidenav): drawer stuck in animating state if transition does not start - #33723
Open
lazerg wants to merge 3 commits into
Open
fix(material/sidenav): drawer stuck in animating state if transition does not start#33723lazerg wants to merge 3 commits into
lazerg wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the drawer adds the
mat-drawer-animatingclass as soon as it's toggled and only removes it ontransitionend, however no transition will run if it's toggled back to its previous state before the browser has rendered it. This leaves the drawer stuck in the animating state and preventsopenedChangefrom emitting.These changes end the animation manually if a transition didn't start.
Fixes #33722.