fix(material/tooltip): prevent tooltip from showing when hovering unrelated elements - #33717
Open
pandikapinata wants to merge 1 commit into
Open
fix(material/tooltip): prevent tooltip from showing when hovering unrelated elements#33717pandikapinata wants to merge 1 commit into
pandikapinata wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
recheck |
1 task
pandikapinata
force-pushed
the
fix/tooltip-select-popover-hover
branch
from
August 22, 2026 15:18
652bb94 to
8dc3a9c
Compare
crisbeto
reviewed
Aug 22, 2026
crisbeto
left a comment
Member
There was a problem hiding this comment.
This isn't a good way to fix it, because it can end up ignoring events from nested elements that may be sticking out of the trigger (e.g. how we have the touch targets on buttons). It'll break a ton of tests internally and it seems like it's breaking some of the external ones as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trigger can have a popover-based overlay nested inside it (e.g. an open mat-select panel), and that overlay's full-viewport backdrop ends up as a DOM descendant of the trigger.
mouseenterfires on an element and all of its ancestors, so hovering anywhere on the page while such a backdrop was present re-firedmouseenteron the trigger, showing the tooltip even though the pointer wasn't visually near it.Guards the
mouseenterhandler by checking that a trusted pointer event is actually within the trigger's own bounds before showing the tooltip.Synthetic events dispatched in tests aren't trusted, so existing test coverage is unaffected.
Fixes #32747