Skip to content

fix(schematics): only emit FirebaseOptions keys in the generated app config #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armando-navarro wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

fix(schematics): only emit FirebaseOptions keys in the generated app config #3707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/schematics/setup/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ import {
} from '../utils';
import { appPrompt, featuresPrompt, projectPrompt, userPrompt } from './prompts';

// FirebaseOptions keys — apps.sdkconfig responses include management-API extras that initializeApp() rejects.
const firebaseOptionsKeys = [
'apiKey', 'authDomain', 'databaseURL', 'projectId', 'storageBucket',
'messagingSenderId', 'appId', 'measurementId', 'recaptchaSiteKey',
];

export interface SetupConfig extends DeployOptions {
firebaseProject: FirebaseProject,
firebaseApp?: FirebaseApp,
Expand Down Expand Up @@ -92,8 +98,11 @@ export const ngAddSetupProject = (
firebaseApp = await appPrompt(firebaseProject, undefined, { projectRoot });

const result = await firebaseTools.apps.sdkconfig('web', firebaseApp.appId, { nonInteractive: true, projectRoot });
sdkConfig = result.sdkConfig;
delete sdkConfig.locationId;
sdkConfig = Object.fromEntries(
firebaseOptionsKeys
.filter(key => result.sdkConfig[key] !== undefined)
.map(key => [key, result.sdkConfig[key]])
);
setupConfig.sdkConfig = sdkConfig;
setupConfig.firebaseApp = firebaseApp;
// set up data connect locally if data connect hasn't already been initialized.
Expand Down
Loading