Skip to content

refactor(schematics): derive the firebase-tools version message from a shared constant #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armando-navarro merged 2 commits into from
Jul 9, 2026
+5 −2
Merged

refactor(schematics): derive the firebase-tools version message from a shared constant #3704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4a9a75
refactor(schematics): derive the firebase-tools version message from …
armando-navarro Jul 7, 2026
0f2eac6
Merge branch 'main' into fix/firebase-tools-min-version-constant
armando-navarro Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/schematics/firebaseTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ declare global {
var firebaseTools: FirebaseTools|undefined;
}

// The minimum firebase-tools version the schematics require.
const minFirebaseToolsVersion = '14.0.0';

export const getFirebaseTools = () => globalThis.firebaseTools ?
Promise.resolve(globalThis.firebaseTools) :
new Promise<FirebaseTools>((resolve, reject) => {
Expand Down Expand Up @@ -44,8 +47,8 @@ export const getFirebaseTools = () => globalThis.firebaseTools ?
globalThis.firebaseTools = firebaseTools;
const version = firebaseTools.cli.version();
console.log(`Using firebase-tools version ${version}`);
if (semverCompare(version, '14.0.0') === -1) {
console.error('firebase-tools version 14.0.0+ is required, please upgrade and run again');
if (semverCompare(version, minFirebaseToolsVersion) === -1) {
console.error(`firebase-tools version ${minFirebaseToolsVersion}+ is required, please upgrade and run again`);
return Promise.reject();
}
return firebaseTools;
Expand Down
Loading