Repository navigation
refactor(@angular/build): run initialization tasks concurrently in library builder - #34297
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…brary builder Moving target project name validation before async operations allows early exit if missing. Additionally, normalizing library options, initializing xxHash, and purging the stale build disk cache concurrently via Promise.all avoids serial awaiting during builder startup.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the executeLibraryBuilder function by refactoring sequential asynchronous calls into a concurrent execution using Promise.all. Specifically, normalizeLibraryOptions, initializeHash, and purgeStaleBuildCache are now run in parallel to improve performance. No review comments were provided, and there is no feedback to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving target project name validation before async operations allows early exit if missing. Additionally, normalizing library options, initializing xxHash, and purging the stale build disk cache concurrently via Promise.all avoids serial awaiting during builder startup.