Skip to content

fix(@angular/build): fallback to build target preserveSymlinks option in karma runner#33528

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:karma-links
Jul 8, 2026
Merged

fix(@angular/build): fallback to build target preserveSymlinks option in karma runner#33528
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:karma-links

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

When running unit tests with karma, the preserveSymlinks option was only read from the unit test builder options which is always undefined, as unitTestOptions.preserveSymlinks is only configured for non standalone runners.

… in karma runner

When running unit tests with karma, the `preserveSymlinks` option was only read from the unit test builder options which is always undefined, as `unitTestOptions.preserveSymlinks` is only configured for non standalone runners.
@alan-agius4 alan-agius4 requested a review from clydin July 8, 2026 08:00
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Karma unit test executor to fall back to the build target's preserveSymlinks option when the unit test option is not explicitly defined. There are no review comments, and I have no additional feedback to provide.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 8, 2026
@alan-agius4 alan-agius4 merged commit 41bd100 into angular:main Jul 8, 2026
42 of 43 checks passed
@alan-agius4 alan-agius4 deleted the karma-links branch July 8, 2026 14:29
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants