Skip to content

Reorganize repository: Move AI Sample Catalog#181

Merged
JolandaVerhoef merged 4 commits into
mainfrom
reorganize-ai-samples
Jul 20, 2026
Merged

Reorganize repository: Move AI Sample Catalog#181
JolandaVerhoef merged 4 commits into
mainfrom
reorganize-ai-samples

Conversation

@JolandaVerhoef

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the repository by moving the main sample catalog into the ai-sample-catalog subdirectory, updating the root configuration files, and applying minor formatting cleanups across several Kotlin files. The review feedback highlights a few important issues: hardcoded local file URLs were accidentally introduced in the root README.md, the .gitignore inside the subdirectory needs standard wildcards to properly ignore build artifacts in submodules, and the InferenceModeDropdown composable is missing a Modifier parameter, which violates the repository's style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread ai-sample-catalog/.gitignore Outdated
Comment on lines +1 to +7
/build
/.gradle
/.idea
/.kotlin
app/google-services.json
/local.properties
.DS_Store

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The .gitignore file inside ai-sample-catalog uses leading slashes (e.g., /build, /local.properties), which only match files/directories at the root of the ai-sample-catalog directory. This means build directories and local properties files inside submodules (like app/ or samples/*) won't be ignored if this project is opened standalone.\n\nWe should update it to use standard directory wildcards to ensure all build artifacts and local configuration files are properly ignored.

build/\n.gradle/\n.idea/\n.kotlin/\n**/local.properties\n**/google-services.json\n.DS_Store

selectedMode: InferenceMode,
onModeSelected: (InferenceMode) -> Unit,
) {
fun InferenceModeDropdown(selectedMode: InferenceMode, onModeSelected: (InferenceMode) -> Unit) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide, every composable function (except top-level screen composables) should take a Modifier as its first optional parameter with a default value of Modifier. This allows callers to pass modifiers down and ensures consistent layout behavior. Please add the modifier parameter and apply it to the root Box of InferenceModeDropdown.

fun InferenceModeDropdown(\n    selectedMode: InferenceMode,\n    onModeSelected: (InferenceMode) -> Unit,\n    modifier: Modifier = Modifier,\n) {
References
  1. Every composable function (except top level screen composable) should take a Modifier as a parameter with a default value. It should be positionned as the first optional parameter. (link)

@JolandaVerhoef
JolandaVerhoef force-pushed the reorganize-ai-samples branch 2 times, most recently from 841df5c to d25f9c7 Compare July 20, 2026 12:16
JolandaVerhoef and others added 3 commits July 20, 2026 13:30
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@JolandaVerhoef
JolandaVerhoef force-pushed the reorganize-ai-samples branch from d25f9c7 to c1b08d7 Compare July 20, 2026 12:31
disk-size: 6000M
heap-size: 600M
script: ./gradlew connectedDebugAndroidTest
script: cd ai-sample-catalog && ./gradlew connectedDebugAndroidTest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

      script: ./gradlew connectedDebugAndroidTest
      working-directory: ai-sample-catalog

@JolandaVerhoef
JolandaVerhoef merged commit ec94197 into main Jul 20, 2026
3 checks passed
@JolandaVerhoef
JolandaVerhoef deleted the reorganize-ai-samples branch July 20, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants