Reorganize repository: Move AI Sample Catalog#181
Conversation
There was a problem hiding this comment.
Code Review
This pull request reorganizes the repository by moving the main sample catalog into the ai-sample-catalog subdirectory, updating the root configuration files, and applying minor formatting cleanups across several Kotlin files. The review feedback highlights a few important issues: hardcoded local file URLs were accidentally introduced in the root README.md, the .gitignore inside the subdirectory needs standard wildcards to properly ignore build artifacts in submodules, and the InferenceModeDropdown composable is missing a Modifier parameter, which violates the repository's style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| /build | ||
| /.gradle | ||
| /.idea | ||
| /.kotlin | ||
| app/google-services.json | ||
| /local.properties | ||
| .DS_Store |
There was a problem hiding this comment.
The .gitignore file inside ai-sample-catalog uses leading slashes (e.g., /build, /local.properties), which only match files/directories at the root of the ai-sample-catalog directory. This means build directories and local properties files inside submodules (like app/ or samples/*) won't be ignored if this project is opened standalone.\n\nWe should update it to use standard directory wildcards to ensure all build artifacts and local configuration files are properly ignored.
build/\n.gradle/\n.idea/\n.kotlin/\n**/local.properties\n**/google-services.json\n.DS_Store
| selectedMode: InferenceMode, | ||
| onModeSelected: (InferenceMode) -> Unit, | ||
| ) { | ||
| fun InferenceModeDropdown(selectedMode: InferenceMode, onModeSelected: (InferenceMode) -> Unit) { |
There was a problem hiding this comment.
According to the repository style guide, every composable function (except top-level screen composables) should take a Modifier as its first optional parameter with a default value of Modifier. This allows callers to pass modifiers down and ensures consistent layout behavior. Please add the modifier parameter and apply it to the root Box of InferenceModeDropdown.
fun InferenceModeDropdown(\n selectedMode: InferenceMode,\n onModeSelected: (InferenceMode) -> Unit,\n modifier: Modifier = Modifier,\n) {References
- Every composable function (except top level screen composable) should take a Modifier as a parameter with a default value. It should be positionned as the first optional parameter. (link)
841df5c to
d25f9c7
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
d25f9c7 to
c1b08d7
Compare
| disk-size: 6000M | ||
| heap-size: 600M | ||
| script: ./gradlew connectedDebugAndroidTest | ||
| script: cd ai-sample-catalog && ./gradlew connectedDebugAndroidTest |
There was a problem hiding this comment.
script: ./gradlew connectedDebugAndroidTest
working-directory: ai-sample-catalog
No description provided.