vulkan: Track swapchain present fences for offscreen replay synchronization - #35
Open
olehkuznetsov wants to merge 1 commit into
Open
Conversation
…zation - Track VkSwapchainPresentFenceInfoEXT/KHR fences in shadow_fences_ regardless of surface_index, preventing replay hangs on offscreen swapchain present fences. - Add null checks and bounds verification when decoding present fence arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes replay synchronization hangs during frame looping when using offscreen/virtual swapchains (or default
--swapchain offscreenmode):VkSwapchainPresentFenceInfoEXT/KHRfence handling inVulkanReplayConsumerBase::OverrideQueuePresentKHRoutside ofoptions_.surface_index != -1scope. When using--swapchain offscreenor virtual swapchains, present fences are now recorded inshadow_fences_so subsequent fence waits (vkWaitForFences/vkGetFenceStatus) do not block indefinitely.pFences.GetLength()andswapchainCountwhen decoding present fence arrays.Testing
frame_loop_validation.pyon Android with offscreen swapchain frame looping.