Add ability to steam audio as base64 encoded json - #123
Closed
Dyster2000 wants to merge 1 commit into
Closed
Dyster2000 wants to merge 1 commit into
Dyster2000 wants to merge 1 commit into
Conversation
Author
|
This fixed a couple bugs.
Then, per the title, I added the ability to send audio base64 encoded wrapped in json. |
Owner
|
Thank you for the PR and for identifying these issues. The metadata argument bug was valid and has already been fixed separately. For the other changes, I prefer to keep the current streaming behavior and audio format of the Community Edition, so I won't be adding the JSON/base64 audio streaming mode or merging the remaining changes from this PR. Closing this PR, but thank you for the contribution and for reporting the metadata issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.