Skip to content

Add ability to steam audio as base64 encoded json - #123

Closed
Dyster2000 wants to merge 1 commit into
amigniter:mainfrom
Dyster2000:base64-audio-stream
Closed

Dyster2000 wants to merge 1 commit into
amigniter:mainfrom
Dyster2000:base64-audio-stream

Conversation

@Dyster2000

Copy link
Copy Markdown

No description provided.

@Dyster2000

Copy link
Copy Markdown
Author

This fixed a couple bugs.

  1. In stream_function when it is parsing "start" parms, it checked if metadata was set, but then passes argv[2] to the is_valid_utf8() function, instead of [5] (or metadata).
  2. I updated the AudioStreamer::isConnected() function as I found it started streaming the audio as soon as the WebSocketClient connected, so I was having multiple frames of audio written out before the send_initial_metadata() was called.

Then, per the title, I added the ability to send audio base64 encoded wrapped in json.

@amigniter

Copy link
Copy Markdown
Owner

Thank you for the PR and for identifying these issues.

The metadata argument bug was valid and has already been fixed separately.

For the other changes, I prefer to keep the current streaming behavior and audio format of the Community Edition, so I won't be adding the JSON/base64 audio streaming mode or merging the remaining changes from this PR.

Closing this PR, but thank you for the contribution and for reporting the metadata issue.

@amigniter amigniter closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants