Repository navigation
Conversation
- Share an inline Octicons SVG across the sidebar, settings, command center and timeline. - Use the host theme color and retain the Octicons MIT notice. - Require the Paseo 0.13 SVG icon API and align SDK type dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Restores the GitHub brand mark in the sidebar, settings, command center and timeline cards using one inline Octicons SVG. This follows #12: Lucide 1 removed brand icons, so restoring the old
"Github"name would make client registration fail again. The SVG usescurrentColorand includes the Octicons MIT notice.Inline SVG icons are supported from Paseo 0.13.0-beta.1. Update the manifest, documentation and SDK/client/protocol type dependencies accordingly, so older hosts reject the plugin through the version requirement instead of failing during registration. The SDK bump overlaps #18; its broader host API migration remains separate.
References: Lucide 1 migration, Octicons source.
Checks
npm run typecheckpassesnpm run lintpasses, including the project rules (two existing complexity warnings inscripts/lib/scan.mjs)npm testpasses — 55 testspaseo plugin reload github-integrationloads cleanly against a real daemonfindSvgIconProblemaccepts the SVG; the manifest accepts 0.13.0-beta.2 and 0.13.0 and rejects 0.12.0Nix was unavailable locally.
UI
On macOS Paseo 0.13.0-beta.2, verified the GitHub mark in the sidebar and screen header, and the board loaded 14 pull requests. Visual verification covered the wide light-theme desktop view; native, dark/compact views and the timeline card were not visually exercised.
Paseo version
Minimum: 0.13.0-beta.1, which introduces
PluginSvgIconand theIcon icon={...}API. Runtime verified on 0.13.0-beta.2.