Keep overlay visible while transcribing - #793
Conversation
Greptile SummaryThe PR removes the normal-dictation early-hide branch so the existing “Transcribing” overlay remains visible until final transcription completes.
|
|
Hi is there a after video? I see the before video! Thank you! seems like a nice PR! |
|
This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the |
|
Thanks! Here’s the after video: FluidVoice-PR-793-after.mp4This was captured against commit |
|
This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the |
161422b to
fa0b6c3
Compare
fa0b6c3 to
0385a96
Compare
|
Rebased onto current main and resolved the conflict while preserving the new Spoken Send path. Local validation and all PR checks pass. Ready for review when you have time. |
Description
Keep the normal dictation overlay visible in its existing “Transcribing” state until final transcription finishes, then hide it through the shared post-output lifecycle.
The regression came from a normal-dictation-only branch that requested an asynchronous overlay hide before
asr.stop()began. Removing that special case lets normal dictation use the same processing lifecycle already used by AI, Command, Rewrite, prompt-test, and sandbox routes.Type of Change
Related Issue or Discussion
Closes #676.
Testing
swiftlint --strict --config .swiftlint.yml Sources(SwiftLint is not installed locally)swiftformat --config .swiftformat Sources(SwiftFormat is not installed locally)xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'Also verified with
swiftc -parse,git diff --check, an unsigned app build, and a real normal-dictation stop cycle. Runtime benchmarks confirmedprocessing=truebeforeasr.stop(), the overlay remained visible while final transcription ran, and hide began only afterasr.stop()returned.Screenshots / Video
Before: reporter’s screen recording showing the overlay disappearing before transcription completes.
After: normal dictation keeps the overlay active through final processing and completes in the Test Playground. The final three seconds are a still of the completed result for readability.
Notes
This removes 19 net lines and adds no new state or abstraction.
AI assistance: Codex was used for implementation and validation.