Skip to content

Fix text insertion mode description wrapping - #791

Open
so1omon563 wants to merge 2 commits into
altic-dev:mainfrom
so1omon563:codex/issue-776-text-insertion-wrap
Open

Fix text insertion mode description wrapping#791
so1omon563 wants to merge 2 commits into
altic-dev:mainfrom
so1omon563:codex/issue-776-text-insertion-wrap

Conversation

@so1omon563

@so1omon563 so1omon563 commented Aug 5, 2026

Copy link
Copy Markdown

Description

Allow option descriptions in Settings to wrap instead of truncating at narrower window widths. Shared toggle rows now wrap consistently, and the Activation Mode and Text Insertion Mode descriptions take the available leading space while their pickers keep the existing fixed width.

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

Closes #776.

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26.5.2
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources (SwiftLint is not installed locally)
  • Ran formatter locally: swiftformat --config .swiftformat Sources (SwiftFormat is not installed locally)
  • Ran tests locally: xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'

Also verified with swiftc -parse, git diff --check, an unsigned app build, and narrow-width visual QA.

Screenshots / Video

After: narrow Settings window showing Activation Mode, Text Insertion Mode, and the shared option rows wrapping beside fixed-width controls.

Settings option descriptions wrapping at narrow window width
  • No UI/visual changes; screenshots/video are not applicable.

Notes

AI assistance: Codex was used for implementation and validation.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The PR Policy check is blocking this PR because required template information is missing.

Please update the PR description with:

  • Screenshots / Video

Visual files detected:

  • Sources/Fluid/UI/SettingsView.swift

Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template.

If this remains incomplete for 48 hours after opening, the PR may be closed.

@github-actions github-actions Bot added needs screenshots Pull request needs screenshot or video evidence. and removed needs screenshots Pull request needs screenshot or video evidence. labels Aug 5, 2026
@so1omon563
so1omon563 marked this pull request as ready for review August 5, 2026 16:05
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adjusts Settings layout behavior so option descriptions can wrap at narrow window widths while preserving fixed-width trailing controls.

  • Gives Activation Mode and Text Insertion Mode descriptions the available leading width.
  • Applies consistent multiline wrapping to shared toggle rows.
  • Removes the now-unnecessary per-row wrapping option.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (3): Last reviewed commit: "Wrap option descriptions consistently" | Re-trigger Greptile

@altic-dev

Copy link
Copy Markdown
Owner

But why wrap only one field while rest are hanging?

@so1omon563

Copy link
Copy Markdown
Author

Good point. I updated the shared Options description layout so all toggle descriptions wrap consistently, and adjusted Activation Mode to follow the same layout instead of special-casing Text Insertion Mode.

That is in commit 97f40a8. I rechecked Swift parsing, git diff --check, the unsigned build, and the narrow-width Settings layout.

@so1omon563
so1omon563 force-pushed the codex/issue-776-text-insertion-wrap branch from 97f40a8 to 38d566b Compare August 19, 2026 17:20
@so1omon563

Copy link
Copy Markdown
Author

Following up on the earlier feedback: option descriptions now wrap consistently across the shared Settings layout, and the branch is current with main. Local validation and PR checks are green whenever you have a chance to take another look.

@altic-dev

Copy link
Copy Markdown
Owner

Hi, thanks for the nice PR. Would you be able to attach a screenshot so I can take a look at it? Thank you so much.

Copy link
Copy Markdown
Author

Whoops, the screenshot was still from the earlier version of the fix. I’ve replaced it with an updated one showing the broader wrapping changes across Activation Mode, Text Insertion Mode, and the shared option rows.

Settings option descriptions wrapping at narrow window width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]

2 participants