fix: Opinion BUY cap units + ungated fallback + double breaker record - #135
Open
Frank-zhu0404 wants to merge 1 commit into
Open
Frank-zhu0404 wants to merge 1 commit into
Frank-zhu0404 wants to merge 1 commit into
Conversation
…ord (alsk1992#127) Opinion BUY size is quote-token spend, so validate/record notional as size rather than price*size. Refuse direct Opinion place fallbacks without executionService. Batch fallback uses executeOrder so the breaker is not double-counted. Closes alsk1992#127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
Summary
Follow-up to #115 / #120. Fixes three remaining safety issues around Opinion / batch execution:
size/amountis quote-token spend (USDC), not shares. Validation and breaker accounting now usesizefor Opinion BUY (stillprice * sizefor SELL / other venues).opinion_place_order/opinion_place_orders_batchno longer call the venue directly whenexecutionServiceis absent; they require the execution service so breaker, maxOrderSize, and dry-run apply.executeOrderinstead ofbuyLimit/sellLimit, so the final batch loop records each result once.Test plan
tsc --noEmitcleantests/execution/batch-order-safety.test.ts: