Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi/SPEC_COMMIT
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2859133debbec7d5be7573492e0b0d7cc194d0bf
50f4e7209fed7ace6ffe7783de2d7256c3c5150a
13 changes: 13 additions & 0 deletions openapi/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6459,6 +6459,7 @@ components:
mentionsIssues,
unresolvedThreads,
awaitingWorkflowApproval,
checksIncomplete,
reviewRequestedFromMe,
empty,
allowedActions,
Expand Down Expand Up @@ -6662,6 +6663,18 @@ components:
`ci` is pending (other runs are going) or failing for another
reason too. Always present; false on Forgejo, which has no
such state.
checksIncomplete:
type: boolean
description: |
True while the forge has not yet listed every check of the head
commit, so `checks` counts some of them and the rest will arrive:
a client shouldn't present the counts as final. A fact only; the
client decides how to say it. Always present, and false when the
list is complete or the forge can't tell. On Forgejo it is true
when a run that is still running has jobs the counts leave out,
or has no job yet. On GitHub it is always false: the rollup
reports its checks by state and says nothing about checks still
to be created.
reviewComments:
type: integer
minimum: 0
Expand Down
16 changes: 16 additions & 0 deletions src/forge_dashboard/_generated/models/pull_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,15 @@ class PullRequest:
`ci` is pending (other runs are going) or failing for another
reason too. Always present; false on Forgejo, which has no
such state.
checks_incomplete (bool): True while the forge has not yet listed every check of the head
commit, so `checks` counts some of them and the rest will arrive:
a client shouldn't present the counts as final. A fact only; the
client decides how to say it. Always present, and false when the
list is complete or the forge can't tell. On Forgejo it is true
when a run that is still running has jobs the counts leave out,
or has no job yet. On GitHub it is always false: the rollup
reports its checks by state and says nothing about checks still
to be created.
review_comments (int): How many review comments the pull request has, the ones on a
line of code. Ordinary conversation comments are counted apart,
in `conversationComments`. Always present, and 0 when
Expand Down Expand Up @@ -443,6 +452,7 @@ class PullRequest:
stack_children: list[int]
requested_reviewer_logins: list[str]
awaiting_workflow_approval: bool
checks_incomplete: bool
review_comments: int
conversation_comments: int
closes_issues: list[ClosingIssue]
Expand Down Expand Up @@ -562,6 +572,8 @@ def to_dict(self) -> dict[str, Any]:

awaiting_workflow_approval = self.awaiting_workflow_approval

checks_incomplete = self.checks_incomplete

review_comments = self.review_comments

conversation_comments = self.conversation_comments
Expand Down Expand Up @@ -700,6 +712,7 @@ def to_dict(self) -> dict[str, Any]:
"stackChildren": stack_children,
"requestedReviewerLogins": requested_reviewer_logins,
"awaitingWorkflowApproval": awaiting_workflow_approval,
"checksIncomplete": checks_incomplete,
"reviewComments": review_comments,
"conversationComments": conversation_comments,
"closesIssues": closes_issues,
Expand Down Expand Up @@ -880,6 +893,8 @@ def _parse_stacked_on(data: object) -> None | StackRef:

awaiting_workflow_approval = d.pop("awaitingWorkflowApproval")

checks_incomplete = d.pop("checksIncomplete")

review_comments = d.pop("reviewComments")

conversation_comments = d.pop("conversationComments")
Expand Down Expand Up @@ -1098,6 +1113,7 @@ def _parse_queued(data: object) -> None | QueuedAction | Unset:
stack_children=stack_children,
requested_reviewer_logins=requested_reviewer_logins,
awaiting_workflow_approval=awaiting_workflow_approval,
checks_incomplete=checks_incomplete,
review_comments=review_comments,
conversation_comments=conversation_comments,
closes_issues=closes_issues,
Expand Down