feat(examples): use Chinese ecommerce agent names - #262
Open
sipercai wants to merge 1 commit into
Open
Conversation
ralf0131
approved these changes
Aug 13, 2026
ralf0131
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Clean, focused change — introduces named constants for the Chinese agent display names (售前服务 / 售后服务) and keeps the English identifiers stable. Documentation updates in both READMEs accurately describe the expected trace span names. Tests properly reference the constants instead of hardcoded strings.
Automated review by github-manager-bot
ralf0131
approved these changes
Aug 14, 2026
ralf0131
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Trivial change, well-tested (10 tests pass), documentation updated in both EN and ZH. Good use of named constants for maintainability.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #260. It changes the two ecommerce customer-service agent display names from English to Chinese so that traces for Chinese users show:
invoke_agent 售前服务invoke_agent 售后服务The LangGraph node names, Python identifiers, route values, and tool names remain in English to keep the implementation stable and easy to maintain.
The English and Chinese READMEs now document the expected trace names.
Fixes # (N/A)
Type of change
How Has This Been Tested?
cd examples/ecommerce-customer-service && uv run --isolated --no-project --with-requirements requirements.txt --with-requirements requirements-dev.txt python -m pytest tests -q(10 passed)tox -e precommitinvoke_agentspan names andgen_ai.agent.namevaluesValidation Evidence
invokeworkflowDoes This PR Require a Core Repo Change?
Checklist:
The PR should carry the
Skip Changeloglabel because it only adjusts an example's user-facing agent names and documentation.