feat(picker): support negative default_index, select_all/deselect_all, and prevent marking disabled options - #166
Open
miskatul-anwar wants to merge 2 commits into
Conversation
added 2 commits
August 11, 2026 23:53
…ention, select_all/deselect_all, and cadule fallback
…, and select_all/deselect_all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces negative index support, batch selection methods, and disabled option safety to
pick:Negative
default_indexSupport (src/pick/__init__.py):default_index=-1to select the last option by default), adhering to standard Python indexing behavior.Disabled Option Guard in
mark_index():mark_index()now explicitly verifies that the target option is enabled before modifyingselected_indexes. This prevents disabled options from being marked ifmark_index()is invoked programmatically or by keypress.select_all()&deselect_all()Helper Methods:select_all()anddeselect_all()methods toPickerfor multiselect mode.select_all()selects all enabled options while respecting disabled option status.Standalone
caduleImport Fallback:try...except ImportErrorfallback forcaduleimport sopickcan run in standalone mode without build artifact errors.Testing & Verification
Ran test suite: