Repository navigation
chore(release): prepare @aictrl/cli 0.5.3 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Moved bullet flips 0.5.1 install-check outcome.
🤖 Fix with your agent
Why this matters
This PR moves the Packaging bullets from the 0.5.2 changelog section into a new 0.5.3 section, and the moved bullet reverses its historical claim: the removed 0.5.2 text ended "0.5.1's install check failed while a platform package was not yet visible", while the new 0.5.3 text says "The 0.5.1 and 0.5.2 install checks did not fail, but each installed only three of the four linux-x64 platform packages". The two statements are mutually exclusive accounts of the same CI event, and the diff itself carries no signal that the reversal is a correction. If the old claim was the accurate one, the new rationale justifying the 8.5-minute npm visibility wait is wrong. The new wording is mechanically plausible (npm silently skips a missing optionalDependency, so a partial install reports
added 4 packagesand still passes), which suggests a deliberate correction of an earlier overstatement, but it should be confirmed against the 0.5.1/0.5.2 release CI logs before the changelog ships.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TRUE · already addressed (no further change). This raises the same point as the round-1 finding (#232 (comment)), and this time it asks for exactly the confirmation that was done there. The new wording is a deliberate correction. I checked it against the release CI
smokelogs:successon attempt 1. The install gotETARGETsix times, thenadded 4 packages, and audited 5 packages, thensucceeded on attempt 7.The PR description records the correction in its Correction: line, which links both runs. The rationale for the visibility wait still holds. It does not depend on the old claim: if a platform package is missing when there is one package per host, there is no binary to run.