fix: Home button redirecting to a dead page - #64
Open
webbrain-one wants to merge 1 commit into
Open
Conversation
Update navigation links in index.html and year-specific pages to point to the correct destination. Fixes aialok#54
There was a problem hiding this comment.
Pull request overview
Fixes the “Home” navigation links that were pointing to an incorrect absolute path (/index.html), which can break when the site is hosted under a subpath (e.g., GitHub Pages project sites).
Changes:
- Replaced
href="/index.html"withhref="index.html"across multiple nav menus. - Updated both the primary nav and dropdown “Home” links on several pages.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/pages/third-year.html |
Updates “Home” link in nav and dropdown (currently points to a non-existent src/pages/index.html). |
src/pages/sophomore.html |
Updates “Home” link in nav and dropdown (currently points to a non-existent src/pages/index.html). |
src/pages/senior.html |
Updates “Home” link in nav and dropdown (currently points to a non-existent src/pages/index.html). |
src/pages/freshers.html |
Updates “Home” link in nav and dropdown (currently points to a non-existent src/pages/index.html). |
index.html |
Updates “Home” links on the root page to be relative (fine on the root page). |
Suppressed comments (4)
src/pages/sophomore.html:39
- Dropdown Home link currently targets src/pages/index.html, which doesn’t exist. Use ../../index.html instead.
<a href="index.html">Home</a>
src/pages/third-year.html:39
- This dropdown Home link points to src/pages/index.html (non-existent). Use ../../index.html to navigate back to the site root.
<a href="index.html">Home</a>
src/pages/senior.html:39
- Dropdown Home link resolves to src/pages/index.html which doesn’t exist. Use ../../index.html for the root home page.
<a href="index.html">Home</a>
src/pages/freshers.html:53
- Dropdown Home link points to src/pages/index.html (non-existent). Use ../../index.html to navigate to the root home page.
<a href="index.html">Home</a>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ul id="mobile_ui" class="flex text-lg max-sm:text-base font-medium"> | ||
| <li class="hover:bg-orange-500 p-4 max-sm:p-1 cursor-pointer"> | ||
| <a href="/index.html">Home</a> | ||
| <a href="index.html">Home</a> |
| <ul id="mobile_ui" class="flex text-lg max-sm:text-base font-medium"> | ||
| <li class="hover:bg-orange-500 p-4 max-sm:p-1 cursor-pointer"> | ||
| <a href="/index.html">Home</a> | ||
| <a href="index.html">Home</a> |
| <ul id="mobile_ui" class="flex text-lg max-sm:text-base font-medium"> | ||
| <li class="hover:bg-orange-500 p-4 max-sm:p-1 cursor-pointer"> | ||
| <a href="/index.html">Home</a> | ||
| <a href="index.html">Home</a> |
| <!-- Home link --> | ||
| <li class="hover:bg-orange-500 p-4 max-sm:p-1 cursor-pointer"> | ||
| <a href="/index.html">Home</a> | ||
| <a href="index.html">Home</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54