Repository navigation
[AAASM-6457] ⬆️ (node-sdk): Bump core pin to d4093e89b - #538
Conversation
…to None Core's AssemblyConfig gained org_id and registration_key, so the shim's struct literals no longer compile against the new pin. This SDK does not expose an org claim yet: both fields are None and registration stays org-less. The pin and the initializers are one change because neither compiles without the other. Refs AAASM-6457 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
OWNER-MERGE-REVIEW head=8d237bf8b65b992b106b0efd0a38dc2cbddcd098 verdict=PASS blocking=0 reviewer=claude-independent-agent |
Brings in the FUNDING.yml-only change (HORO-2531) so the branch is current. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4
|
OWNER-MERGE-REVIEW head=ec595a1f16e15c3413148d8615bf3af004211d95 verdict=PASS blocking=0 reviewer=claude-independent-agent |
|
|
OWNER-ADMIN-MERGE (same-identity REVIEW_REQUIRED deadlock exception, engineering-workflow exception 2) for head ec595a1. Verified identity: Chisanan232 (author; org ai-agent-assembly role=admin, checked just now via orgs//memberships). Only remaining blocker: GitHub required approving review, which the PR author cannot supply for their own PR. At this head: independent adversarial review clean (no Critical/High); one Medium (registration_key None now falls back to env AA_REGISTRATION_KEY via core) is disclosed in the shim comment and Jira AAASM-6457 comment 30539 and is non-blocking (below High; same core behaviour python-sdk#390 inherits); OWNER-MERGE-REVIEW PASS comment posted; 32 checks green after coverage re-run; mergeable, 0 unresolved threads, 0 REQUEST_CHANGES. Merge by merge commit, pinned to this head, on the owner explicit instruction; host Allow once / Deny prompt applies. |



Target
Task summary:
Core
agent-assemblymaind4093e89baddedorg_idandregistration_keytoAssemblyConfig. This repo pinned core at0044d515(1610 commits behind), and a bump does not compile as-is: the twoAssemblyConfig { .. }literals innative/aa-ffi-node/src/lib.rs(connect,register) lack the new fields. This change bumps the pin tod4093e89band sets both fields toNone, so registration stays org-less and behaviour for callers is unchanged. The pin and the initializers are one commit because neither compiles without the other. node-sdk does not expose an org claim here; that is a separate design and secret-handling decision.Task tickets:
Key point change (optional):
native/aa-ffi-node/Cargo.toml:aa-sdk-clientandaa-protorev0044d515->d4093e89b;Cargo.lockregenerated (cargo update -p aa-sdk-client -p aa-proto);src/lib.rs:org_id: None, registration_key: Noneat both literals. Note: a registration key in the process environment (AA_REGISTRATION_KEY) is still resolved by core during register.Effecting Scope
Verified locally in
native/aa-ffi-nodeagainst the new pin with an isolated target dir, on the disk-admission queue:cargo update -p aa-sdk-client -p aa-proto,cargo check --all-targets --locked,cargo clippy --all-targets --locked -- -D warnings,cargo test -p aa-ffi-node-core --lockedall exit 0. Not run locally: the napi addon build and the TypeScript suites (pnpm native:build,pnpm typecheck,pnpm lint,pnpm test); the CI build-addon and test jobs are the authoritative check. Theaa-protobuild.rs differences between the old and new pin were not separately reviewed beyond the successful compile.Description
d4093e89b07d8ba1c38e6caa92637d2e8edb65d7; setorg_idandregistration_keytoNone; regenerate the lockfile.🤖 Generated with Claude Code
https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4