Skip to content

[AAASM-6457] ⬆️ (node-sdk): Bump core pin to d4093e89b - #538

Merged
Chisanan232 merged 2 commits into
mainfrom
v0.0.1/AAASM-6457/deps/bump_core_org_fields
Nov 10, 2026
Merged

Chisanan232 merged 2 commits into
mainfrom
v0.0.1/AAASM-6457/deps/bump_core_org_fields

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Target

  • Task summary:

    Core agent-assembly main d4093e89b added org_id and registration_key to AssemblyConfig. This repo pinned core at 0044d515 (1610 commits behind), and a bump does not compile as-is: the two AssemblyConfig { .. } literals in native/aa-ffi-node/src/lib.rs (connect, register) lack the new fields. This change bumps the pin to d4093e89b and sets both fields to None, so registration stays org-less and behaviour for callers is unchanged. The pin and the initializers are one commit because neither compiles without the other. node-sdk does not expose an org claim here; that is a separate design and secret-handling decision.

  • Task tickets:

  • Key point change (optional):

    native/aa-ffi-node/Cargo.toml: aa-sdk-client and aa-proto rev 0044d515 -> d4093e89b; Cargo.lock regenerated (cargo update -p aa-sdk-client -p aa-proto); src/lib.rs: org_id: None, registration_key: None at both literals. Note: a registration key in the process environment (AA_REGISTRATION_KEY) is still resolved by core during register.

Effecting Scope

  • Action Types:
    • ✏️ Modifying existing something
      • 🟢 No breaking change
  • Scopes:
    • 🪡 API client and transport
    • 🚀 Building
      • 🔗 Dependencies
  • Additional description:
    Verified locally in native/aa-ffi-node against the new pin with an isolated target dir, on the disk-admission queue: cargo update -p aa-sdk-client -p aa-proto, cargo check --all-targets --locked, cargo clippy --all-targets --locked -- -D warnings, cargo test -p aa-ffi-node-core --locked all exit 0. Not run locally: the napi addon build and the TypeScript suites (pnpm native:build, pnpm typecheck, pnpm lint, pnpm test); the CI build-addon and test jobs are the authoritative check. The aa-proto build.rs differences between the old and new pin were not separately reviewed beyond the successful compile.

Description

  • Bump core pin to d4093e89b07d8ba1c38e6caa92637d2e8edb65d7; set org_id and registration_key to None; regenerate the lockfile.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4

…to None

Core's AssemblyConfig gained org_id and registration_key, so the shim's
struct literals no longer compile against the new pin. This SDK does not
expose an org claim yet: both fields are None and registration stays
org-less. The pin and the initializers are one change because neither
compiles without the other.

Refs AAASM-6457

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chisanan232

Copy link
Copy Markdown
Contributor Author

OWNER-MERGE-REVIEW head=8d237bf8b65b992b106b0efd0a38dc2cbddcd098 verdict=PASS blocking=0 reviewer=claude-independent-agent

Brings in the FUNDING.yml-only change (HORO-2531) so the branch is current.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4
@Chisanan232

Copy link
Copy Markdown
Contributor Author

OWNER-MERGE-REVIEW head=ec595a1f16e15c3413148d8615bf3af004211d95 verdict=PASS blocking=0 reviewer=claude-independent-agent

@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

OWNER-ADMIN-MERGE (same-identity REVIEW_REQUIRED deadlock exception, engineering-workflow exception 2) for head ec595a1. Verified identity: Chisanan232 (author; org ai-agent-assembly role=admin, checked just now via orgs//memberships). Only remaining blocker: GitHub required approving review, which the PR author cannot supply for their own PR. At this head: independent adversarial review clean (no Critical/High); one Medium (registration_key None now falls back to env AA_REGISTRATION_KEY via core) is disclosed in the shim comment and Jira AAASM-6457 comment 30539 and is non-blocking (below High; same core behaviour python-sdk#390 inherits); OWNER-MERGE-REVIEW PASS comment posted; 32 checks green after coverage re-run; mergeable, 0 unresolved threads, 0 REQUEST_CHANGES. Merge by merge commit, pinned to this head, on the owner explicit instruction; host Allow once / Deny prompt applies.

@Chisanan232
Chisanan232 merged commit 8a7ba03 into main Nov 10, 2026
33 checks passed
@Chisanan232
Chisanan232 deleted the v0.0.1/AAASM-6457/deps/bump_core_org_fields branch November 10, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant