Repository navigation
[AAASM-6358] ⬆️ (deps): Clear high advisories failing dependency-audit - #526
Conversation
… gate Floors body-parser@2 >=2.4.0, zod@4 >=4.6.6, undici@7 >=7.30.1 and declares vite ^6.4.4 as a devDependency (it was an auto-installed vitest peer that the override alone could not move). dependency-audit command now exits 0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
LGTM (self-review record, not a GitHub approval) pinned to head 935d555. Reviewed diff: package.json (+vite devDependency), pnpm-workspace.yaml (overrides body-parser@2 ^2.4.0, zod@4 ^4.6.6, undici@7 ^7.30.1, vite ^6.4.4 with advisory references), pnpm-lock.yaml. No src/, public API, peer range or native change; no audit ignore/allowlist added. Evidence: Sole blocker: same-identity REVIEW_REQUIRED (1 approval + code owner; author is the only code owner). Merging under the owner-only admin-merge exception (AAASM-5858), identity verified before merge. |



Target
Task summary:
Make the
dependency-auditjob (corepack pnpm@11.13.0 --pm-on-fail=ignore audit --audit-level=high, all deps, no ignore list) pass on main. No advisory is suppressed or allowlisted.Task tickets:
Key point change:
Measured at remote/main 3fe715f with the CI command: exit 1, 18 vulns (3 low, 11 moderate, 4 high). The originally reported proxy-addr (critical), source-map-js and @modelcontextprotocol/sdk advisories were already fixed by existing overrides. The 4 remaining highs:
body-parser@2: ^2.4.0(was ^2.3.0)zod@4: ^4.6.6undici@7: ^7.30.1vite: ^6.4.4plusvite ^6.4.4devDependencyThe vite override alone did not move the lockfile: vite is an auto-installed vitest peer and pnpm kept the prior resolution, so vite is now declared as a devDependency. Overrides are scoped to a major (
zod@4,undici@7) so other majors are untouched.Effecting Scope
src/, public API,peerDependenciesor native code. Changed files:package.json(devDependency),pnpm-workspace.yaml,pnpm-lock.yaml.Evidence
Same CI command, before then after: exit 1 with 18 vulns (3 low, 11 moderate, 4 high), then exit 0 with 8 vulns (2 low, 6 moderate, 0 high or critical).
Local, all exit 0:
pnpm install --frozen-lockfile,pnpm typecheck,pnpm lint,pnpm test(752 passed, 5 skipped),pnpm build.Not verified: the native build was not run (no Rust or native change). The 8 remaining low and moderate advisories are below the gate threshold and were left alone. GitHub's push banner reports Dependabot alerts on the default branch (4 critical, 7 high) that this local audit does not show. They may come from
website/or other manifests, and I did not investigate them here.🤖 Generated with Claude Code
https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4