Skip to content

[AAASM-6358] ⬆️ (deps): Clear high advisories failing dependency-audit - #526

Merged
Chisanan232 merged 1 commit into
mainfrom
v0.0.1/AAASM-6358/fix/dep_audit
Oct 25, 2026
Merged

Chisanan232 merged 1 commit into
mainfrom
v0.0.1/AAASM-6358/fix/dep_audit

Conversation

@Chisanan232

@Chisanan232 Chisanan232 commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Target

  • Task summary:

    Make the dependency-audit job (corepack pnpm@11.13.0 --pm-on-fail=ignore audit --audit-level=high, all deps, no ignore list) pass on main. No advisory is suppressed or allowlisted.

  • Task tickets:

  • Key point change:

    Measured at remote/main 3fe715f with the CI command: exit 1, 18 vulns (3 low, 11 moderate, 4 high). The originally reported proxy-addr (critical), source-map-js and @modelcontextprotocol/sdk advisories were already fixed by existing overrides. The 4 remaining highs:

    Advisory Package Reached via Fix
    GHSA-27r3-jxmh-p828 body-parser 2.x <2.4.0 @openai/agents-core > @modelcontextprotocol/sdk > express override body-parser@2: ^2.4.0 (was ^2.3.0)
    GHSA-mrhx-c7xc-m3w5 zod <4.6.6 @langchain/core > langsmith > openai override zod@4: ^4.6.6
    GHSA-xjj6-f33q-929c undici 7.x <7.30.1 ai > @ai-sdk/gateway > @ai-sdk/provider-utils override undici@7: ^7.30.1
    GHSA-587h-7wmj-h5pm vite <=6.4.3 vitest (dev only) override vite: ^6.4.4 plus vite ^6.4.4 devDependency

    The vite override alone did not move the lockfile: vite is an auto-installed vitest peer and pnpm kept the prior resolution, so vite is now declared as a devDependency. Overrides are scoped to a major (zod@4, undici@7) so other majors are untouched.

Effecting Scope

  • Action Types:
    • ✏️ Modifying existing something
      • 🟢 No breaking change
    • 🍀 Improving something (security)
  • No change to src/, public API, peerDependencies or native code. Changed files: package.json (devDependency), pnpm-workspace.yaml, pnpm-lock.yaml.

Evidence

Same CI command, before then after: exit 1 with 18 vulns (3 low, 11 moderate, 4 high), then exit 0 with 8 vulns (2 low, 6 moderate, 0 high or critical).

Local, all exit 0: pnpm install --frozen-lockfile, pnpm typecheck, pnpm lint, pnpm test (752 passed, 5 skipped), pnpm build.

Not verified: the native build was not run (no Rust or native change). The 8 remaining low and moderate advisories are below the gate threshold and were left alone. GitHub's push banner reports Dependabot alerts on the default branch (4 critical, 7 high) that this local audit does not show. They may come from website/ or other manifests, and I did not investigate them here.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4

… gate

Floors body-parser@2 >=2.4.0, zod@4 >=4.6.6, undici@7 >=7.30.1 and declares
vite ^6.4.4 as a devDependency (it was an auto-installed vitest peer that
the override alone could not move). dependency-audit command now exits 0.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TLpw696KjUDUg4QjH83En4
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

LGTM (self-review record, not a GitHub approval) pinned to head 935d555.

Reviewed diff: package.json (+vite devDependency), pnpm-workspace.yaml (overrides body-parser@2 ^2.4.0, zod@4 ^4.6.6, undici@7 ^7.30.1, vite ^6.4.4 with advisory references), pnpm-lock.yaml. No src/, public API, peer range or native change; no audit ignore/allowlist added. Evidence: pnpm audit --audit-level=high (the exact dependency-audit CI command) exit 1 with 4 high before -> exit 0 after (8 low/moderate remain, below the gate). Local install --frozen-lockfile, typecheck, lint, test (752 passed, 5 skipped), build all exit 0. Hosted CI at this head: 31/31 check runs success including audit; repo has no required status contexts. Not covered: website/pnpm-lock.yaml Dependabot alerts (docs site, separate manifest, tracked separately).

Sole blocker: same-identity REVIEW_REQUIRED (1 approval + code owner; author is the only code owner). Merging under the owner-only admin-merge exception (AAASM-5858), identity verified before merge.

@Chisanan232
Chisanan232 merged commit 974bd9b into main Oct 25, 2026
31 checks passed
@Chisanan232
Chisanan232 deleted the v0.0.1/AAASM-6358/fix/dep_audit branch October 25, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant