fix: write the group-org tuple the way the model defines it - #9
Merged
Conversation
Creating a group failed outright: Invalid tuple 'organization:...#org@group:...'. Reason: relation 'organization#org' not found The model puts the relation on the group — `type group ... define org: [organization]` — so the group is the object and the organization is the user. groupOrgTuple had the two swapped, naming a relation organization does not have. OpenFGA rejects the whole Write, so the admin tuple in the same batch never landed either. Reconciliation read the same inverted shape in two places, so a corrected tuple would have been classified as unmanaged and swept as stale. Fixed alongside. The existing test compared groupOrgTuple against itself, which held for either orientation and is why this shipped green. It now asserts the literal user and object strings. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a group failed outright with
Invalid tuple 'organization:...#org@group:...'. Reason: relation 'organization#org' not found.The model puts the relation on the group —
type group ... define org: [organization]— so the group is the object and the organization is the user.groupOrgTuplehad the two swapped, naming a relationorganizationdoes not have. OpenFGA rejects the entire Write, so the admin tuple batched with it never landed either.Reconciliation read the same inverted shape in two places (
isManagedGroupTuple,tupleBackedByStore), so a correctly-written tuple would have been classified as unmanaged and swept as stale on the next pass. Fixed alongside.The existing test compared
groupOrgTupleagainst itself, which holds for either orientation — that is why this shipped green. It now asserts the literal user and object strings. Full suite passes.