fix(ziti): wire workload underlay egress - #578
Conversation
|
Verification summary for #577: Commands run:
Results:
Notes:
|
|
Pushed The previous bootstrap PR run failed during provisioning because it pointed at unreleased chart versions:
I kept the source-of-truth Ziti config changes in this PR, but restored the default chart pins to the latest published releases:
Local verification:
CI is running on the new head: |
|
Pushed What changed:
Verification:
Note: |
|
Implementation update: Changes pushed for the architecture-backed runtime Ziti underlay contract. Validation summary:
E2E result note:
Local validation commands/results are included in the PR summary comment there and match the final handoff. |
Verification SummaryUpdated bootstrap wiring for selector-aware runtime Ziti underlay egress. New commit:
Changes:
Commands run:
Results:
This matches k8s-runner PR #74 at/after |
|
Updated bootstrap values for the k8s-runner runtime ingressgateway backend egress fix. New commit:
What changed:
Local checks:
|
noa-lucent
left a comment
There was a problem hiding this comment.
I found two blocking release-pin issues:
[major] stacks/platform/variables.tf still pins agents_orchestrator_chart_version to 0.13.18. The new env values in stacks/platform/main.tf need to be deployed with the released agents-orchestrator chart/image that contains the PR #220 ziti-enroll/runtime DNS changes; otherwise bootstrap will not actually run code that understands the new config.
[major] stacks/apps/variables.tf still pins k8s_runner_chart_version to 0.10.14 while stacks/apps/main.tf wires the new workloadEgressNetworkPolicy.zitiWorkloadDNS and zitiUnderlay.endpoints schema. If that published chart predates PR #74, Helm will ignore these values and render the old NetworkPolicy without the required Ziti DNS/controller/router/ingress egress rules.
Please bump both defaults to the released chart versions containing the paired fixes before merge.
|
Addressed Noa's release-pin review in What changed:
Local validation:
Required PR check is green:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The k8s-runner pin is updated to a chart version that includes the new NetworkPolicy values, but bootstrap now pins agents-orchestrator 0.13.19, which is tagged from the still-open PR #220 while that PR still has unresolved requested changes. Please wait for and pin the corrected/accepted agents-orchestrator release before merging this bootstrap source-of-truth change.
Verified: Terraform fmt checks passed for stacks/deps, stacks/ziti, stacks/platform, and stacks/apps; Helm chart metadata/values for agents-orchestrator:0.13.19 and k8s-runner:0.10.15 were inspectable from GHCR.
| type = string | ||
| description = "Version of the agents-orchestrator Helm chart published to GHCR" | ||
| default = "0.13.18" | ||
| default = "0.13.19" |
There was a problem hiding this comment.
[major] This now points bootstrap at agents-orchestrator chart 0.13.19, but that release tag resolves to commit a4ed503 from the still-open PR #220, which still has unresolved changes-requested feedback. Bootstrap is supposed to pin the released, accepted orchestrator fix; pinning an unresolved PR release means this stack would deploy code we have already marked as needing changes. Please wait for the corrected agents-orchestrator PR/release and pin that accepted version here before merging bootstrap.
e9743b8 to
d670052
Compare
d670052 to
79b08d0
Compare
|
Implemented the Ziti controller runtime advertisement fix. Summary:
Validation:
CI:
Follow-up validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. I’m keeping changes requested because the remaining release-pin blocker is still present: stacks/platform/variables.tf still pins agents_orchestrator_chart_version = "0.13.19" while the owning agents-orchestrator PR #220 is still open and currently on hold for scope/root-cause re-audit. Bootstrap should not merge a source-of-truth pin to an unresolved/re-audited orchestrator release.
The k8s-runner pin and workload egress wiring look aligned with chart 0.10.15, and the Terraform checks passed locally.
Verified locally:
terraform -chdir=stacks/deps fmt -check -diffterraform -chdir=stacks/ziti fmt -check -diffterraform -chdir=stacks/platform fmt -check -diffterraform -chdir=stacks/apps fmt -check -diffterraform -chdir=stacks/deps init -backend=false -input=false && terraform -chdir=stacks/deps validateterraform -chdir=stacks/ziti init -backend=false -input=false && terraform -chdir=stacks/ziti validateterraform -chdir=stacks/platform init -backend=false -input=false && terraform -chdir=stacks/platform validateterraform -chdir=stacks/apps init -backend=false -input=false && terraform -chdir=stacks/apps validate
Verification updateFixed the hardcoded Kubernetes DNS service IP in PR #578.
Test & lint summaryCommands run: terraform -chdir=stacks/platform fmt -check
terraform -chdir=stacks/platform init -backend=false -input=false
terraform -chdir=stacks/platform validate
git diff --checkResults:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The previous release-pin blocker is still present: bootstrap still pins agents_orchestrator_chart_version = "0.13.19" while the owning agents-orchestrator PR #220 remains open/unaccepted. Please wait for and pin the corrected released agents-orchestrator chart before merging this bootstrap source-of-truth change.
I did not rerun the full Terraform validation because this release pin remains blocking.
| type = string | ||
| description = "Version of the agents-orchestrator Helm chart published to GHCR" | ||
| default = "0.13.18" | ||
| default = "0.13.19" |
There was a problem hiding this comment.
[major] This still pins bootstrap to agents-orchestrator chart 0.13.19, but the owning agents-orchestrator fix PR #220 is still open and has not landed as an accepted release. This was the remaining blocker in the prior reviews: bootstrap is the source-of-truth deployment pin, so it should wait for and pin the corrected released orchestrator chart that includes the accepted Ziti enrollment/runtime DNS behavior rather than an unresolved PR-era release.
Current AO/Bootstrap blocker classificationI inspected the latest llm-proxy PR #68 E2E failure ( Evidence
ClassificationThis belongs to the existing Bootstrap PR #578 consumption path, not a new PR and not an llm-proxy PR #68 patch. The exact mismatch is: current E2E provisioning from bootstrap Action takenI triggered AO PR #220 E2E against the active bootstrap PR branch to validate the intended paired path:
Local validationCommands run: git diff --check
terraform -chdir=stacks/platform fmt -check
terraform -chdir=stacks/apps fmt -checkResults:
|
Summary
3.2.0/3.0.0).ZITI_ENROLLMENT_DNS_UPSTREAMwhile keepingWORKLOAD_DNS_UPSTREAMonziti-workload-dns./32endpoints.Fixes #577.
Verification
terraform -chdir=stacks/deps fmt -check -diffterraform -chdir=stacks/ziti fmt -check -diffterraform -chdir=stacks/platform fmt -check -diffterraform -chdir=stacks/apps fmt -check -diffterraform -chdir=stacks/deps init -backend=false -input=false && terraform -chdir=stacks/deps validateterraform -chdir=stacks/ziti init -backend=false -input=false && terraform -chdir=stacks/ziti validateterraform -chdir=stacks/platform init -backend=false -input=false && terraform -chdir=stacks/platform validateterraform -chdir=stacks/apps init -backend=false -input=false && terraform -chdir=stacks/apps validate