Deprecate the internal platform registration methods - #181
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
RegisterPlatformOrganization and RegisterPlatformImage exist because provisioning had no identity: they are called with none, fenced by Istio principal, and create-if-absent so a re-run cannot overwrite an edit. Both are a second creation path on a service that already has one, existing only for install. Provisioning now calls the ordinary Gateway API as a cluster admin, so neither has a caller left. A provisioned resource is created the same way an operator's is, which is what lets a release correct a resource it shipped earlier -- create-if-absent could not. Deprecated rather than deleted, matching how the flavor methods were retired: existing callers keep compiling while they migrate, and the services stop implementing them. buf breaking stays clean. Refs architecture/changes/2026-08-08-one-step-install.md
vitramir
force-pushed
the
retire-platform-registration-clean
branch
from
August 8, 2026 21:49
d534914 to
f5e151e
Compare
vitramir
changed the title
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegisterPlatformOrganizationandRegisterPlatformImageexist because provisioning had no identity: they are called with none, fenced by Istio principal, and create-if-absent so a re-run cannot overwrite an edit. Both are a second creation path on a service that already has one, existing only for install.Provisioning now calls the ordinary Gateway API as a cluster admin, so neither has a caller left. A provisioned resource is created the same way an operator's is, which is what lets a release correct a resource it shipped earlier — create-if-absent could not.
Deprecated, not deleted, matching how the flavor methods on
RunnersServicewere retired: existing callers keep compiling while they migrate, and the services stop implementing them.buf lintandbuf breakingare both clean againstmain.The service-side removals (implementations, Istio policies, the provisioner Job) land in
agynio/organizationsandagynio/images. Those depend on the provisioning controller reconciling organizations and images first — otherwise a release ships with nothing creating the system organization.Part of one-step-install; follows #180.