Feature/issue 47 ingestion api - #24
Open
Khantdotcom wants to merge 3 commits into
Open
Conversation
9 tasks
Author
|
@joeldickson Can you review this PR please? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joeldickson
feat: add /command telemetry, sessionId, and rspack support (#47)
Extends the ingestion API to capture the full local dev lifecycle,
accommodating the new multi-phase telemetry generated by devfeedback-js.
Key changes:
POST /commandendpoint for full lifecycle events (install,devserver, clientready) with non-blocking background queueing.
POST /rspackendpoint (accepting bothrspackandrsbuild),while keeping backward compatibility on
/webpackfor legacy clients.sessionId(uuid) across all telemetry endpoints (webpack,vite, command) to allow stitching spans from
installtoclientready.CommandEventtable and aCommandEventNpmTimerchild table(Option 2) to track and aggregate expensive npm install phases org-wide.
spooledAta first-class nullable column to accurately reflectdelayed event delivery without conflating with ingestion time.
prebundledto a nullable boolean to properly handle itstri-state nature (true, false, absent) for Vite/Rolldown.
AddCommandEventsAndSessionIdEF Core migration.and backward compatibility for older CLI clients.
Resolves #47
Companion to agoda-com/devfeedback-js#46