Sweep deps and cut 2.6.2 - #71
Merged
Merged
Conversation
coverage 7.15.2 -> 7.15.3, the only available bump. Version to 2.6.2, and the same caveat as the node SDK: nothing here reaches a consumer. The only commit since v2.6.1 is a one-line ci.yml change and coverage is a dev dependency, so the published wheel is unchanged. Both consumers (core/store, python-commerce) declare `agentscore-py>=2.6.1`, which already accepts it, so no downstream manifest edit follows. uv.lock re-locked after the version bump, not just after the dependency change. The lock embeds the project's OWN version, so a pyproject bump leaves it stale with nothing erroring and no gate noticing: the two files simply disagree about what the package is. It was sitting at 2.6.1 here and `uv lock` moved it to 2.6.2. Gates run with the project's own invocations, including vulture through the exact CI command (`. vulture_whitelist.py --min-confidence 80 --exclude .venv`) rather than a bare `vulture`, which reports low-confidence noise the project deliberately filters: ruff check and format clean, ty clean, vulture clean, 183 tests passed with 100% coverage against a 95% floor.
CI ran `uv sync --frozen --all-extras`, which resolves today only because uv installs the default `dev` group implicitly. Every linting and type tool this workflow then invokes (ruff, ty, vulture, pytest-cov) lives in `[dependency-groups] dev`, so the job depends on that default rather than asking for what it needs. Nothing is broken now. The failure it invites arrives the day a second, non-default group is added: bare sync skips it, the tools that group provides vanish from the venv, and the step fails for a reason that looks nothing like its cause. Same shape as the local trap where a bare sync silently drops the extras and pytest stops collecting. `--all-groups` makes the requirement explicit and matches the convention the rest of the workspace follows. Gates re-run against the corrected sync: ruff check clean, ty clean, vulture clean, 183 tests passed with 100% coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency sweep for this repo, plus a version bump so it can be released.
coverage7.15.2 to 7.15.3, the only available bump.Same caveat as the node SDK, and it decides whether this is worth publishing: nothing here reaches a consumer. The only commit since v2.6.1 is a one-line
ci.ymlchange and coverage is a dev dependency, so the published wheel is unchanged.uv.lockwas re-locked after the version bump, not just after the dependency change. The lock embeds the project's own version, so apyproject.tomlbump leaves it stale with nothing erroring and no gate noticing: the two files simply disagree about what the package is. It was sitting at 2.6.1 anduv lockmoved it to 2.6.2.Type of change
Public API
None. No exported class, function signature, wire format, or response shape changed. The published wheel is unchanged; the only difference is a dev dependency.
No migration for callers. Both consumers in this workspace (
core/store,python-commerce) declareagentscore-py>=2.6.1, which already accepts 2.6.2, so no manifest edit is required downstream.Test plan
No tests added, because no behavior changed. The existing suite was run to confirm the bump breaks nothing:
uv run pytest: 183 passed, 8 skipped, 100% coverage against a 95% floorruff checkandruff format --check: cleanuv run ty check: cleanuv run vulture . vulture_whitelist.py --min-confidence 80 --exclude .venv: cleanVulture is run through the project's exact CI invocation rather than a bare
vulture, which reports low-confidence findings the project deliberately filters out and would read as a regression that is not there.Reproduce with
uv sync --all-extras --all-groupsfollowed by those four commands.Checklist