fix(checkout): malformed-402 re-challenge must run pre_validate -> v2.5.8 - #90
Merged
Conversation
…500 for dynamic pricing) Parity with node-commerce 2.7.1. The 2.5.7 malformed-credential re-challenge skipped pre_validate, so a merchant whose compute_pricing reads state that pre_validate populates crashed with a 500 instead of a 402. Fix: strip the junk credential and re-enter handle() so the full discovery flow (pre_validate + pricing + minting + compose) runs. Regression test added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parity hotfix for 2.5.7 (mirrors node-commerce 2.7.1). Malformed-credential 402 re-challenge skipped pre_validate, 500ing for dynamic-pricing merchants. Fix: strip the credential + re-enter handle() (full discovery flow). Regression test added. Gate green: ruff/ty/vulture/pytest (1835, 95.48%).
🤖 Generated with Claude Code