refactor(challenge): build_accepted_methods + build_how_to_pay consume *RailSpec; async - #41
Merged
Conversation
…e *RailSpec; async build_accepted_methods and build_how_to_pay now accept *RailSpec instances directly instead of plain dicts. The helpers are async because RecipientLike supports async factories (used by Stripe-multichain merchants that mint fresh deposit addresses per PaymentIntent). Single canonical type per rail: vendors declare one TempoRailSpec / X402BaseRailSpec / SolanaMppRailSpec / StripeRailSpec / TempoSessionRailSpec and pass the same instance to every helper. No more restating the same recipient across four different per-helper config shapes. Migrates the existing test suite + multi_rail_merchant example inline. Scrubs internal version annotations from rail_spec docstrings in both SDKs as part of the same diff. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`build_accepted_methods` and `build_how_to_pay` now accept `*RailSpec` instances directly instead of plain dicts. The helpers are async because `RecipientLike` supports async factories (used by Stripe-multichain merchants that mint fresh deposit addresses per PaymentIntent).
Single canonical type per rail: vendors declare one `TempoRailSpec` / `X402BaseRailSpec` / `SolanaMppRailSpec` / `StripeRailSpec` / `TempoSessionRailSpec` and pass the same instance to every helper.
`build_how_to_pay` does not resolve `RecipientLike` factories — the block surfaces CLI commands, none of which include the recipient string. `build_accepted_methods` does resolve, since each entry carries `pay_to`.
Migrates the existing test suite + `multi_rail_merchant` example inline. Other examples (api_provider, variable_cost_merchant, ...) migrate in follow-up PRs.
Test plan
🤖 Generated with Claude Code