feat: flatten payment directive + headers + override builders to kwargs - #34
Merged
Merged
Conversation
Drops the wrapper construction for the 5 payment-side builders in
directive.py / headers.py / settlement_override.py:
- build_payment_request_blob(PaymentRequestInput(...))
→ build_payment_request_blob(*, amount_usd, rail=None, ...)
- payment_directive(PaymentDirectiveInput(...))
→ payment_directive(*, id, realm, request, rail=None, ...)
- build_payment_directive(BuildPaymentDirectiveInput(...))
→ build_payment_directive(*, rail, id, realm, amount_usd, ...)
- build_payment_headers(BuildPaymentHeadersInput(...))
→ build_payment_headers(*, rails=None, order_id="", realm="", x402=None)
- settlement_override_header(SettlementOverrides(amount=X))
→ settlement_override_header(*, amount=X)
Deleted from public exports: PaymentRequestInput, PaymentDirectiveInput,
BuildPaymentDirectiveInput, BuildPaymentHeadersInput, SettlementOverrides.
Kept (data shapes consumers construct): PaymentHeadersRail,
PaymentHeadersResult, X402AcceptsBlock.
Tests: 1031 passed / 3 skipped, 95.05% coverage. ty + ruff clean.
Migrated callers in tests/ + examples/api_provider.py +
examples/variable_cost_merchant.py + discovery/probe.py.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the wrapper construction for the 5 payment-side builders in
directive.py,headers.py, andsettlement_override.py. Same pattern as #32 + #33.Builders flattened
build_payment_request_blob(PaymentRequestInput(...))build_payment_request_blob(*, amount_usd, rail=None, ...)payment_directive(PaymentDirectiveInput(...))payment_directive(*, id, realm, request, rail=None, ...)build_payment_directive(BuildPaymentDirectiveInput(...))build_payment_directive(*, rail, id, realm, amount_usd, ...)build_payment_headers(BuildPaymentHeadersInput(...))build_payment_headers(*, rails=None, order_id="", realm="", x402=None)settlement_override_header(SettlementOverrides(amount=X))settlement_override_header(*, amount=X)Deleted from exports
PaymentRequestInput,PaymentDirectiveInput,BuildPaymentDirectiveInput,BuildPaymentHeadersInput,SettlementOverrides.Kept (data shapes consumers construct)
PaymentHeadersRail,PaymentHeadersResult,X402AcceptsBlock.Test plan
uv run pytest tests/— 1031 passed / 3 skipped, 95.05% coverageuv run ty check agentscore_commerce/— cleanuv run ruff check . && uv run ruff format .— cleantests/test_payment_{directive,headers,misc}.py,examples/api_provider.py,examples/variable_cost_merchant.py,agentscore_commerce/discovery/probe.py