test: lock public-surface barrel exports - #30
Merged
Conversation
Add tests asserting every TEC-302 lift-up helper is importable from its documented path. Triggered by a Node-side gap on loadUCPSigningKeyFromEnv: the helper was defined in src/identity/ucp-jwks.ts but never re-exported from src/index.ts, and the helper's own test imported from the module path so it never noticed. Consumers couldn't import it from the documented top-level barrel until the export was patched. Python's barrel was correct the first time around but the same gap could hit any future helper. These tests give us a single-failure signal in CI whenever a future helper lands in a submodule and is forgotten in the __init__.py re-export. Covers: hash_operator_token, load_ucp_signing_key_from_env + LoadUCPSigningKeyOptions, detect_rail_from_headers, zero_amount_carve_out, usd_to_atomic, classify_orchestration_error, classify_x402_settle_result, extract_payment_signer, read_x402_payment_header. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vvillait88
added a commit
that referenced
this pull request
May 14, 2026
## Summary Additive update to the README inventory table — documents the helpers that landed in PRs #22–#29 + the public-surface guard in #30. Pure docs, no code changes. ## What was added **`agentscore_commerce.identity` (package level)** row: - `load_ucp_signing_key_from_env` + `LoadUCPSigningKeyOptions` (env-driven UCP signing key loader; cached, alg-detected, sanitized errors) - `hash_operator_token` (sha256 hex of plaintext `opc_...` for merchants persisting `operator_token_id` to their own DB) **`agentscore_commerce.payment`** row: - `extract_payment_signer` now documents both the positional `x402_payment_header` path AND the `authorization_header=` MPP kwarg (`did:pkh:eip155` / `did:pkh:solana` source DIDs) - `detect_rail_from_headers` (returns `"x402"` / `"mpp"` / `None`) - `classify_orchestration_error` (companion to `classify_x402_settle_result` for orchestration-time exceptions) - `zero_amount_carve_out` (skip CDP/pympp upstream when settle_cents == 0) - `usd_to_atomic` (Decimal-based USD → atomic int, ROUND_HALF_UP) ## Test plan Docs-only; no code changes. Markdown renders cleanly in the existing table. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locks every public helper's documented import path so a future barrel-export gap fails CI.
The trigger was a Node-side gap on
loadUCPSigningKeyFromEnvduring the recent helper lift: the function was defined insrc/identity/ucp-jwks.tsbut never re-exported fromsrc/index.ts. The helper's own test imported from the module path so the gap stayed invisible until a consumer tried importing from the documented top-level barrel.Python's barrel was correct the first time around, but the same gap could hit any future helper. These tests give us a single-failure signal in CI whenever a helper lands in a submodule and is forgotten in the
__init__.pyre-export.What's covered
agentscore_commerce.identity→hash_operator_token,load_ucp_signing_key_from_env,LoadUCPSigningKeyOptionsagentscore_commerce.payment→detect_rail_from_headers,zero_amount_carve_out,usd_to_atomic,classify_orchestration_error,classify_x402_settle_result,extract_payment_signer,read_x402_payment_headerEach test asserts the barrel-imported symbol is the same object as the module-level one (
barrel.foo is module.foo), so a future barrel rewrite that re-binds rather than re-exports also fails.Test plan
uv run pytest tests/test_public_surface.py— 5 passeduv run ruff check+uv run ty checkclean