ci: typecheck through the pinned script, not bunx - #69
Merged
Conversation
`bunx tsc --noEmit` resolves TypeScript independently of the project, so CI was not necessarily compiling with the version this repo pins. That is a documented trap: a bunx-resolved tsc has fetched a different major and printed its help text while exiting non-zero, which reads exactly like a real type error and sends a verification down a false path. It is live now rather than theoretical: TypeScript is held at ^6 org-wide and 7.0.2 is published, so bunx had a newer major available to reach for. `bun run typecheck` runs the same `tsc --noEmit` against the pinned version. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI ran
bunx tsc --noEmit, which resolves TypeScript independently of the project, so the typecheck was not guaranteed to use the version this repo pins. Switched tobun run typecheck, which runs the sametsc --noEmitagainst the pinned compiler.Type of change
Public API
None. This changes only how CI invokes the type checker; no shipped code, exported type or signature changes.
Test plan
bun run typecheckpasses locally (exit 0), running the sametsc --noEmitthe script has always defined.Worth stating why this is a fix rather than tidying: the org holds TypeScript at
^6and 7.0.2 is published, sobunxhad a newer major available to reach for. That failure mode is on record. A bunx-resolvedtscfetched a different major and printed its help text while exiting non-zero, which reads exactly like a real type error and sends a verification down a false path. A CI check that can fail for a reason unrelated to the thing being tested is worse than one that does not run, because it looks like a finding.Found while auditing hook/CI parity across the workspace; pay carried the identical line and is fixed in its own PR.
Checklist