fix(e2b): reject incomplete process streams without exit code - #2828
Open
guslegend0510 wants to merge 7 commits into
Open
fix(e2b): reject incomplete process streams without exit code#2828guslegend0510 wants to merge 7 commits into
guslegend0510 wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zouyx
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 描述
AgentScope-Java Version
2.0.3-SNAPSHOT
Description
Fixes #2824.
E2bEnvdProcessClient.drainStartStream()previously returnedInteger.MIN_VALUEwhen the envd response stream ended before a process exit event was received.The sentinel was then interpreted as a real non-zero process exit code, causing an incomplete transport response to be misreported as a command failure.
This change:
Integer.MIN_VALUEfallback.IOExceptionwhen the stream ends without a process exit code.The missing exit code is treated as an incomplete transport response rather than being assumed to mean success.
Tests
Targeted tests:
mvn -pl agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b \ -am \ -Dtest=E2bEnvdProcessClientTest \ -Dsurefire.failIfNoSpecifiedTests=false \ testResult: 10 tests passed.
Full module tests:
mvn -pl agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b \ -am testResults:
agentscope-core: 2294 tests, 0 failuresagentscope-harness: 834 tests, 0 failuresagentscope-extensions-sandbox-e2b: 14 tests, 0 failuresChecklist