fix(harness): add global progress to subagent completion notifications - #2827
Open
guslegend0510 wants to merge 7 commits into
Open
fix(harness): add global progress to subagent completion notifications#2827guslegend0510 wants to merge 7 commits into
guslegend0510 wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[3/8 tasks terminal]COMPLETED,FAILED, andCANCELLEDtasks as terminalHarnessAgent.BuilderBehavior
Completion notifications now include a best-effort snapshot of the current session's task progress:
Background subagent task 'task-3' (agent=worker) has completed [3/8 tasks terminal].
Tasks from other sessions are not included.
If TaskRepository.listTasks(...) fails, the notification falls back to the original format and is still delivered to the inbox with a wakeup signal.
Testing
Added tests for [1/5 tasks terminal] and [5/5 tasks terminal]
Verified COMPLETED, FAILED, and CANCELLED are terminal, while RUNNING is not
Verified session isolation
Verified fallback behavior when task progress lookup fails
Verified static and dynamic middleware use the same notification format
Spotless passed
agentscope-core: 2294 tests passed
agentscope-harness: 838 tests passed
Closes #2792