fix(harness): stop cancelled async subagents - #2826
Open
guslegend0510 wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.3-SNAPSHOT
Description
Fixes #2789.
Background
Calling
task_cancelupdated the task status toCANCELLED, but did not stop an already-running local subagent.The task repository only cancelled the wrapping
CompletableFuture. SinceCompletableFuture.cancel(true)does not interrupt an executing supplier, the subagent could continue making model and tool calls after cancellation.Timeout-promoted tasks had a similar issue because the original Reactor
Disposablewas not retained by the adopted background task.Changes
LocalTaskRunSpecAdoptedTaskRunSpecBackgroundTaskcancellation atomic and idempotent.Future<?>.cancelRequested=trueandCANCELLEDbefore invoking local cancellation handles.COMPLETEDorFAILEDresults.WorkspaceTaskRepositoryControlPlaneTaskRepository/cancel404 race without skipping local cancellation.Remote Agent Protocol behavior remains unchanged apart from cancellation ordering and late-result protection.
Cancellation semantics
Validation
mvn spotless:checkpassed for the affected modules.git diff --checkpassed.Regression coverage includes:
Checklist
mvn spotless:apply