Make malformed extensions fatal in Agent Plugins 1.1 - #82
Open
jonathanhefner wants to merge 1 commit into
Open
Conversation
Treat a non-object `extensions` field like every other recognized-field schema violation. Keep unknown top-level fields as the sole non-fatal exception so clients can support forward compatibility without weakening strict authoring validation. Leave Agent Plugins 1.0 behavior unchanged, document the loading exception in the strict schema, and align the extension namespace, conformance, and failure wording.
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent Plugins 1.0 permits clients to continue loading when
extensionsis not an object, even though the manifest does not conform to the schema. This PR removes that exception from Agent Plugins 1.1, leaving unknown top-level fields as the sole non-fatal schema violation. The resulting loading rule distinguishes unrecognized fields from malformed recognized fields.Rationale
Unknown top-level fields remain non-fatal because they may be defined by a later Agent Plugins version. Reporting and ignoring them supports forward compatibility without assigning semantics to data the client does not understand. A non-object
extensionsvalue has no equivalent forward-compatibility role:extensionsis a recognized portable field, and its object shape establishes the boundary around client-specific namespaces. Treating it like every other recognized-field violation gives 1.1 a single exception with a single purpose.The schema remains closed rather than accepting unknown top-level fields, preserving typo detection and schema-driven completion. A separate permissive loading schema would duplicate the manifest structure and could drift from the authoring schema. Instead, the schema
$commentexplains how clients apply the unknown-field loading exception while validating against the strict schema.Compatibility
The published 1.0 contract is unchanged. A client that supports both versions selects the appropriate loading behavior from the declared
$schemavalue. This affects only schema-invalid 1.1 manifests; conforming plugins are unaffected.Closes #77.