Favicon: transparent light/dark variants - #8
Open
naman06dev wants to merge 1 commit into
Open
Conversation
The favicon was a 1080px white-mark-on-solid-black square: on a light browser tab it rendered as a black box, and the mark itself occupied only ~58% of the tile, so at 16px it read as a smudge. Extracted the mark, cropped to its bounds, and generated two transparent variants matching the logo colors (#18181B light / #fafafa dark), wired via docs.json's favicon light/dark object so each theme gets the right one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current favicon is a 1080×1080 white-mark-on-solid-black square. Two problems: on a light browser tab it renders as a black box, and the mark occupies only ~58% of the tile, so at 16×16 it reads as a gray smudge (visible on the live site now).
This PR:
#18181Bfor light tabs (same ink aslogo/light.svg),#fafafafor dark tabs (same aslogo/dark.svg).docs.json'sfaviconat the light/dark object so each browser theme gets the matching variant.Replaces the single
favicon.png. Preview both at 32px before merging if you want — they're crisp.🤖 Generated with Claude Code