Repository navigation
fix(examples): return the agent's protocol version from initialize - #205
Open
andreivince wants to merge 1 commit into
Open
andreivince wants to merge 1 commit into
andreivince wants to merge 1 commit into
Conversation
The echo agents returned whatever version the client asked for. The spec says an agent that does not support the requested version must answer with the latest version it supports, so return PROTOCOL_VERSION like examples/agent.py does.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/echo_agent.pyandexamples/http_server.pyanswerinitializewith whateverprotocolVersionthe client sent, so a client asking for 65535 gets 65535 back. The spec says an agent that doesn't support the requested version must answer with the latest one it supports, and the docs suggest starting new agents fromecho_agent.py.Both now return
PROTOCOL_VERSION, likeexamples/agent.pyalready does.Related issues
No issue for this. The TCK cross-check lists it as the echo agent's known
ACP-INIT-003failure (cross-check/run.sh).Testing
initializewith 1, 2 and 65535 onecho_agent.py(spawned liketest_spawn_agent_process_roundtrip) and on thehttp_server.pyapp over HTTP and WebSocket. Main echoes the requested version; this branch answers 1.make checkandmake testpass.No new test, since the TCK already checks this rule against
echo_agent.py.Docs & screenshots
Only the two examples change. No docs page shows this
initializepattern.Checklist
feat:,fix:).make gen-all) are called out if applicable.