Repository navigation
docs(gate): call entry.record() at the end of a completed turn - #8
Merged
Merged
Conversation
… at its start Documents the rule decided after today's production live-fire: the host calls a reply verdict's record() only once the turn has completed. A completed turn that looked counts as read even if it sent nothing; a crashed turn, or one that could not look, records nothing so the conversation stays on the tray and the next wake retries. dismiss/defer are still recorded by gate.run at once. Recording at the start marked the conversation read before the turn's own agentchat_inbox call (empty tray, parked for the wait window), and a crash after recording left the peer blocked by the cold-DM one-message rule. Docs and docstrings only; no behaviour change, no version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs/docstrings only: a
replyverdict'srecord()is called at the end of a turn that completed — never before the turn, never at its start (the turn's ownagentchat_inboxcall then saw an empty tray). A completed turn that looked counts as read even if it sent nothing; a crashed turn, or one that could not look, records nothing and the next wake retries.dismiss/deferunchanged. No code change, no version bump.