Repository navigation
ci: PR template and a check that the description says how the change was verified - #26
Merged
Merged
Conversation
PRs auto-merge when CI is green and any agent or human may open one. The template asks for What changes, Verification (Tests, Review, Live check) and Risk and rollback. The pr-verification job fails a PR whose description has no Verification heading, or a Tests/Review/Live check line that is missing or holds only a placeholder; the failure says which and states the rule. It does not judge what the lines say. PRs from dependabot[bot] and github-actions[bot] pass. The checker (.github/scripts/pr-verification.py, stdlib only) reads the event payload and runs from the base branch, so a PR cannot change the rule it is checked against; the PR that adds it falls back to its own copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Nothing user-visible. PRs now auto-merge when CI is green, so every PR description has to say how the change was verified.
.github/pull_request_template.md: a template with What changes / Verification / Risk and rollback.pr-verificationcheck: fails a PR whose## Verificationsection is missing, or whoseTests:,Review:orLive check:line is empty. The failure message states the rule. Bot PRs pass.pull_request(never_target), and never interpolates the body into the workflow.Verification
pr-verificationrun is the first live check.Risk and rollback
A wrong parser could fail good PRs. The check isn't a required check yet; it's added only after these PRs pass. Rollback: revert, or drop it from the ruleset.